SkTHash: remove()

SkTHash: remove()

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/33d73c39dd3cca7594b3ad4304143872d5f7f570

[mtklein_C, 2015-04-20 20:49:35]

mtklein@chromium.org changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-04-21 13:21:10]

This patch worked great for my use case, thanks!

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp
File tests/HashTest.cpp (right):

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp#newcode60
tests/HashTest.cpp:60: REPORTER_ASSERT(r, (found == nullptr) ==  i < N/2);
The compiler complained about the lack of parenthesis.

[mtklein, 2015-04-21 13:37:57]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-04-21 13:37:57]

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp
File tests/HashTest.cpp (right):

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp#newcode60
tests/HashTest.cpp:60: REPORTER_ASSERT(r, (found == nullptr) ==  i < N/2);
On 2015/04/21 13:21:10, joshualitt wrote:
> The compiler complained about the lack of parenthesis.

Where?

[joshualitt, 2015-04-21 13:40:31]

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp
File tests/HashTest.cpp (right):

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp#newcode60
tests/HashTest.cpp:60: REPORTER_ASSERT(r, (found == nullptr) ==  i < N/2);
On 2015/04/21 13:37:57, mtklein wrote:
> On 2015/04/21 13:21:10, joshualitt wrote:
> > The compiler complained about the lack of parenthesis.
> 
> Where?

== i < N/2
../../tests/HashTest.cpp:60:53: error: suggest parentheses around comparison in
operand of ‘==’ [-Werror=parentheses]

[mtklein, 2015-04-21 13:48:29]

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp
File tests/HashTest.cpp (right):

https://codereview.chromium.org/1057043003/diff/1/tests/HashTest.cpp#newcode60
tests/HashTest.cpp:60: REPORTER_ASSERT(r, (found == nullptr) ==  i < N/2);
On 2015/04/21 13:40:31, joshualitt wrote:
> On 2015/04/21 13:37:57, mtklein wrote:
> > On 2015/04/21 13:21:10, joshualitt wrote:
> > > The compiler complained about the lack of parenthesis.
> > 
> > Where?
> 
> == i < N/2
> ../../tests/HashTest.cpp:60:53: error: suggest parentheses around comparison
in
> operand of ‘==’ [-Werror=parentheses]

Done.

[mtklein, 2015-04-21 13:48:33]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 13:48:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057043003/20001

[joshualitt, 2015-04-21 13:51:24]

On 2015/04/21 13:48:50, I haz the power (commit-bot) wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1057043003/20001

lgtm

[mtklein, 2015-04-21 13:52:41]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-04-21 13:52:44]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-21 13:53:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057043003/20001

[commit-bot: I haz the power, 2015-04-21 13:54:00]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/33d73c39dd3cca7594b3ad4304143872d5f7f570