Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1057033002: Rename the trace filter name to be aligned with the class/method name. (Closed)

Created:
5 years, 8 months ago by qiangchen
Modified:
5 years, 8 months ago
Reviewers:
mcasas, DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the trace filter name to be aligned with the class/method name. BUG=472334 TEST=WebRtcGetUserMediaBrowserTest.TraceVideoCaptureControllerPerformanceDuringGetUserMedia in content_browsertests Committed: https://crrev.com/939cdf30e0df03a7f85eb4ea935284b779454928 Cr-Commit-Position: refs/heads/master@{#323956}

Patch Set 1 #

Patch Set 2 : Rename the TRACE filter name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
qiangchen
Found another occurrence of TRACE name unalignment. Code searched "VideoCaptureController::OnIncomingCapturedData", just found one browser test ...
5 years, 8 months ago (2015-04-02 22:34:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057033002/20001
5 years, 8 months ago (2015-04-03 00:55:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53903)
5 years, 8 months ago (2015-04-03 05:18:30 UTC) #6
mcasas
LGTM
5 years, 8 months ago (2015-04-03 14:04:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057033002/20001
5 years, 8 months ago (2015-04-03 16:08:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54031)
5 years, 8 months ago (2015-04-03 16:21:06 UTC) #11
qiangchen
Can you take a look at this? As we've found and fixed a mismatch between ...
5 years, 8 months ago (2015-04-03 16:47:32 UTC) #13
qiangchen
Can you take a look at it? We've aligned the method name with TRACE filter ...
5 years, 8 months ago (2015-04-03 18:57:32 UTC) #15
DaleCurtis
lgtm
5 years, 8 months ago (2015-04-03 22:00:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057033002/20001
5 years, 8 months ago (2015-04-06 20:36:04 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 21:36:55 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:37:54 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/939cdf30e0df03a7f85eb4ea935284b779454928
Cr-Commit-Position: refs/heads/master@{#323956}

Powered by Google App Engine
This is Rietveld 408576698