Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057013002: Make sure RenderingHelper doesn't allocate a window of size 0x0 (Closed)

Created:
5 years, 8 months ago by dnicoara
Modified:
5 years, 8 months ago
Reviewers:
Owen Lin, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-vda-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure RenderingHelper doesn't allocate a window of size 0x0 0x0 window sizes can be invalid and may cause GL errors. BUG=471550 Committed: https://crrev.com/bd3affcd89b1cd3f0cc436f09176034769466d40 Cr-Commit-Position: refs/heads/master@{#325237}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/common/gpu/media/rendering_helper.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dnicoara
This gets us closer, but there's still an issue.
5 years, 8 months ago (2015-04-02 20:27:36 UTC) #2
Pawel Osciak
5 years, 8 months ago (2015-04-03 03:24:29 UTC) #4
Owen Lin
https://codereview.chromium.org/1057013002/diff/1/content/common/gpu/media/rendering_helper.cc File content/common/gpu/media/rendering_helper.cc (right): https://codereview.chromium.org/1057013002/diff/1/content/common/gpu/media/rendering_helper.cc#newcode259 content/common/gpu/media/rendering_helper.cc:259: if (!display_configurator_->framebuffer_size().IsEmpty()) I would prefer storing the result in ...
5 years, 8 months ago (2015-04-07 03:33:56 UTC) #5
dnicoara
https://codereview.chromium.org/1057013002/diff/1/content/common/gpu/media/rendering_helper.cc File content/common/gpu/media/rendering_helper.cc (right): https://codereview.chromium.org/1057013002/diff/1/content/common/gpu/media/rendering_helper.cc#newcode259 content/common/gpu/media/rendering_helper.cc:259: if (!display_configurator_->framebuffer_size().IsEmpty()) On 2015/04/07 03:33:56, Owen Lin wrote: > ...
5 years, 8 months ago (2015-04-14 13:48:17 UTC) #6
Owen Lin
lgtm
5 years, 8 months ago (2015-04-15 03:16:22 UTC) #7
Pawel Osciak
lgtm
5 years, 8 months ago (2015-04-15 03:37:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057013002/20001
5 years, 8 months ago (2015-04-15 13:29:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 13:32:41 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 13:33:19 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bd3affcd89b1cd3f0cc436f09176034769466d40
Cr-Commit-Position: refs/heads/master@{#325237}

Powered by Google App Engine
This is Rietveld 408576698