Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 1056993003: check_dups: Add a script to check for the same resource in multiple pak files. (Closed)

Created:
5 years, 8 months ago by sadrul
Modified:
5 years, 7 months ago
CC:
grit-developer_googlegroups.com, Mattias Nissler (ping if slow)
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

check_dups: Add a script to check for the same resource in multiple pak files. The usage is: check_dups.py first.pak second.pak ... The script looks at each resource pack, and throws an exception if a resource with the same id exists in more than one resource pack. This can be useful to avoid accidentally increasing the install-size. BUG=tbd

Patch Set 1 #

Patch Set 2 : self-nits #

Patch Set 3 : test #

Patch Set 4 : fix-test-oops #

Patch Set 5 : better-test #

Total comments: 5

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
A grit/format/check_dups.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A grit/format/check_dups_unittest.py View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
M grit/test_suite_all.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sadrul
Hi! The corresponding CL in chrome that uses this script: https://codereview.chromium.org/1055153002/ The tests run OK ...
5 years, 8 months ago (2015-04-02 22:17:29 UTC) #2
Mattias Nissler (ping if slow)
Passing this on to thakis@, who's a much more competent reviewer for this CL. https://codereview.chromium.org/1056993003/diff/80001/grit/format/check_dups.py ...
5 years, 8 months ago (2015-04-07 10:12:38 UTC) #4
sadrul
https://codereview.chromium.org/1056993003/diff/80001/grit/format/check_dups.py File grit/format/check_dups.py (right): https://codereview.chromium.org/1056993003/diff/80001/grit/format/check_dups.py#newcode18 grit/format/check_dups.py:18: On 2015/04/07 10:12:38, Mattias Nissler wrote: > nit: two ...
5 years, 8 months ago (2015-04-07 20:09:30 UTC) #5
Mattias Nissler (ping if slow)
https://codereview.chromium.org/1056993003/diff/80001/grit/format/check_dups.py File grit/format/check_dups.py (right): https://codereview.chromium.org/1056993003/diff/80001/grit/format/check_dups.py#newcode36 grit/format/check_dups.py:36: def main(): On 2015/04/07 20:09:30, sadrul wrote: > On ...
5 years, 8 months ago (2015-04-08 08:29:52 UTC) #6
sadrul
> Let's wait and hear what thakis@ says. thakis@ ping
5 years, 8 months ago (2015-04-09 18:56:48 UTC) #7
Nico
I'm mostly away until next week wednesday. We already have a bunch of similar scripts ...
5 years, 8 months ago (2015-04-09 22:26:18 UTC) #8
sadrul
5 years, 7 months ago (2015-05-13 18:51:35 UTC) #9
This is no longer useful since https://codereview.chromium.org/1115033003/ has
landed.

Powered by Google App Engine
This is Rietveld 408576698