Source/core/layout/LayoutBox.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 98e21d660ef16a29d779d162c7539cd5f550af09..c173699068aeadf9c558ddd027b9bc823fb3c475 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -551,7 +551,7 @@ public:

int intrinsicScrollbarLogicalWidth() const;

int scrollbarLogicalWidth() const { return style()->isHorizontalWritingMode() ? verticalScrollbarWidth() : horizontalScrollbarHeight(); }

int scrollbarLogicalHeight() const { return style()->isHorizontalWritingMode() ? horizontalScrollbarHeight() : verticalScrollbarWidth(); }

- virtual bool scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1);

+ virtual ScrollResultOneDimensional scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1);

bool canBeScrolledAndHasScrollableArea() const;

virtual bool canBeProgramaticallyScrolled() const;

virtual void autoscroll(const IntPoint&);