Source/core/layout/LayoutBox.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: No Overscroll on non-scrollable axes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBox.cpp

diff --git a/Source/core/layout/LayoutBox.cpp b/Source/core/layout/LayoutBox.cpp

index 0dc69e022b5e13d8e96858008db145adf629eb62..c101ccddbe9aa9517040574a79f9981839c1dd4e 100644

--- a/Source/core/layout/LayoutBox.cpp

+++ b/Source/core/layout/LayoutBox.cpp

@@ -699,13 +699,13 @@ int LayoutBox::intrinsicScrollbarLogicalWidth() const

return 0;

}

-bool LayoutBox::scroll(ScrollDirectionPhysical direction, ScrollGranularity granularity, float delta)

+ScrollResultOneDimensional LayoutBox::scroll(ScrollDirectionPhysical direction, ScrollGranularity granularity, float delta)

{

// Presumably the same issue as in setScrollTop. See crbug.com/343132.

DisableCompositingQueryAsserts disabler;

if (!layer() || !layer()->scrollableArea())

- return false;

+ return ScrollResultOneDimensional(false);

return layer()->scrollableArea()->scroll(direction, granularity, delta);

}