Source/platform/scroll/ScrollableArea.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableArea.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollableArea.h

diff --git a/Source/platform/scroll/ScrollableArea.h b/Source/platform/scroll/ScrollableArea.h

index 47ddccfaa4043d727c18a8ae73c8b1baa89dda87..ab48c7ae31f4bfd63a39a4342fee4dba599ed637 100644

--- a/Source/platform/scroll/ScrollableArea.h

+++ b/Source/platform/scroll/ScrollableArea.h

@@ -72,7 +72,7 @@ public:

// host window in the window's coordinate space.

virtual HostWindow* hostWindow() const { return 0; };

- virtual bool scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1);

+ virtual ScrollResultOneDimensional scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1);

virtual void setScrollPosition(const DoublePoint&, ScrollBehavior = ScrollBehaviorInstant);

void scrollToOffsetWithoutAnimation(const FloatPoint&, bool cancelProgrammaticAnimations = true);

void scrollToOffsetWithoutAnimation(ScrollbarOrientation, float offset);