Source/core/layout/LayoutEmbeddedObject.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutEmbeddedObject.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutEmbeddedObject.cpp

diff --git a/Source/core/layout/LayoutEmbeddedObject.cpp b/Source/core/layout/LayoutEmbeddedObject.cpp

index 0d6845afba516ea9fb376ee33eb1cad0b44f5beb..54abba9f82882957882d5f4d976db77369b1c2c6 100644

--- a/Source/core/layout/LayoutEmbeddedObject.cpp

+++ b/Source/core/layout/LayoutEmbeddedObject.cpp

@@ -152,9 +152,9 @@ PaintInvalidationReason LayoutEmbeddedObject::invalidatePaintIfNeeded(

return reason;

}

-bool LayoutEmbeddedObject::scroll(ScrollDirectionPhysical direction, ScrollGranularity granularity, float)

+ScrollResultOneDimensional LayoutEmbeddedObject::scroll(ScrollDirectionPhysical direction, ScrollGranularity granularity, float)

{

- return false;

+ return ScrollResultOneDimensional(false);

}

CompositingReasons LayoutEmbeddedObject::additionalCompositingReasons() const