Source/core/frame/RootFrameViewportTest.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RootFrameViewportTest.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RootFrameViewportTest.cpp

diff --git a/Source/core/frame/RootFrameViewportTest.cpp b/Source/core/frame/RootFrameViewportTest.cpp

index ac99d6c1e8aae7c1dc7edc33359f1e30db2b7557..68d88dfee1283d0a2e839ea4b8d1703f925dd716 100644

--- a/Source/core/frame/RootFrameViewportTest.cpp

+++ b/Source/core/frame/RootFrameViewportTest.cpp

@@ -493,7 +493,7 @@ TEST_F(RootFrameViewportTest, BasicWheelEvent)

ScrollResult result = rootFrameViewport->handleWheel(wheelEvent);

- EXPECT_TRUE(result.didScroll);

+ EXPECT_TRUE(result.didScroll());

EXPECT_POINT_EQ(DoublePoint(50, 50), visualViewport.scrollPositionDouble());

EXPECT_POINT_EQ(DoublePoint(100, 200), layoutViewport.scrollPositionDouble());

EXPECT_EQ(-350, result.unusedScrollDeltaX);