Source/core/frame/RootFrameViewport.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RootFrameViewport.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RootFrameViewport.h

diff --git a/Source/core/frame/RootFrameViewport.h b/Source/core/frame/RootFrameViewport.h

index 55cbc179ffaf2003f279d3611084b399cd47478a..3ff6ec3da3438b01f3d4e9b331e248e13dfaf24d 100644

--- a/Source/core/frame/RootFrameViewport.h

+++ b/Source/core/frame/RootFrameViewport.h

@@ -59,7 +59,7 @@ public:

GraphicsLayer* layerForScrolling() const override;

GraphicsLayer* layerForHorizontalScrollbar() const override;

GraphicsLayer* layerForVerticalScrollbar() const override;

- bool scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1) override;

+ ScrollResultOneDimensional scroll(ScrollDirectionPhysical, ScrollGranularity, float delta = 1) override;

// TODO(bokan): This method should be removed. It should be replaced by

// making EventHandler::handleWheelEvent unpack the WheelEvent and make a

// call to this class' scroll method.