Source/platform/scroll/ScrollAnimator.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollAnimator.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollAnimator.cpp

diff --git a/Source/platform/scroll/ScrollAnimator.cpp b/Source/platform/scroll/ScrollAnimator.cpp

index 06299a25f26b09ef1aee4873017f413128e3a549..e885bbbb21872c6dfa7433eeeae4f0f10d1d53dc 100644

--- a/Source/platform/scroll/ScrollAnimator.cpp

+++ b/Source/platform/scroll/ScrollAnimator.cpp

@@ -54,8 +54,9 @@ ScrollResultOneDimensional ScrollAnimator::scroll(ScrollbarOrientation orientati

{

float& currentPos = (orientation == HorizontalScrollbar) ? m_currentPosX : m_currentPosY;

float newPos = clampScrollPosition(orientation, currentPos + step * delta);

if (currentPos == newPos)

- return ScrollResultOneDimensional(false);

+ return ScrollResultOneDimensional(false, delta);

float usedDelta = (newPos - currentPos) / step;

currentPos = newPos;