Source/web/WebPluginScrollbarImpl.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginScrollbarImpl.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPluginScrollbarImpl.cpp

diff --git a/Source/web/WebPluginScrollbarImpl.cpp b/Source/web/WebPluginScrollbarImpl.cpp

index 5b573f8dd41844ac3adfece3995c4dcbf7f62ff8..5f8d89bd0b8bf22f756b3610b05df29b94dde113 100644

--- a/Source/web/WebPluginScrollbarImpl.cpp

+++ b/Source/web/WebPluginScrollbarImpl.cpp

@@ -358,7 +358,7 @@ bool WebPluginScrollbarImpl::onKeyDown(const WebInputEvent& event)

blink::ScrollGranularity scrollGranularity;

if (WebViewImpl::mapKeyCodeForScroll(keyCode, &scrollDirection, &scrollGranularity)) {

// Will return false if scroll direction wasn't compatible with this scrollbar.

- return m_group->scroll(scrollDirection, scrollGranularity);

+ return m_group->scroll(scrollDirection, scrollGranularity).didScroll;

}

return false;

}