Source/core/frame/FrameView.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index e7578c6dbd3a526feb2e8d4e0b9308246525bf33..c3e96e7abcd785e6681f946fff1ae0b6f0f570d0 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -3271,7 +3271,7 @@ bool FrameView::scroll(ScrollDirection direction, ScrollGranularity granularity)

ScrollDirection physicalDirection =

toPhysicalDirection(direction, isVerticalDocument(), isFlippedDocument());

- return ScrollableArea::scroll(physicalDirection, granularity);

+ return ScrollableArea::scroll(physicalDirection, granularity).didScroll;

}

void FrameView::windowResizerRectChanged()