Source/web/ChromeClientImpl.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added function for comparison Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/LocalFrame.cpp ('K') | « Source/web/ChromeClientImpl.h ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | Source/web/tests/data/mainthread-inner-iframe-overscroll.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index e6392cc88f4c0bac7bafa4aede556edbb27ea627..9f574b7c6c3f47cdbdeac8e1a794ebc3845d4532 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -291,6 +291,14 @@ void ChromeClientImpl::show(NavigationPolicy navigationPolicy)

m_webView->client()->show(policy);

}

+void ChromeClientImpl::didOverscroll(const FloatSize& unusedDelta, const FloatSize& accumulatedRootOverScroll, const FloatPoint& position, const FloatSize& velocity)

+ if (!m_webView->client())

+ return;

+ m_webView->client()->didOverscroll(unusedDelta, accumulatedRootOverScroll, position, velocity);

void ChromeClientImpl::setToolbarsVisible(bool value)

{

m_windowFeatures.toolBarVisible = value;