Source/core/frame/FrameView.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added function for comparison Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameView.h

diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h

index 8032d28a13f7154b70a64ce425bcb231ab67306b..5c4251269dc8ca8c079a386150f9bfe79bfa36e4 100644

--- a/Source/core/frame/FrameView.h

+++ b/Source/core/frame/FrameView.h

@@ -358,7 +358,7 @@ public:

virtual bool isScrollCornerVisible() const override;

virtual bool userInputScrollable(ScrollbarOrientation) const override;

virtual bool shouldPlaceVerticalScrollbarOnLeft() const override;

- virtual bool scroll(ScrollDirection, ScrollGranularity, float delta = 1) override;

+ virtual ScrollResultOneDimensional scroll(ScrollDirection, ScrollGranularity, float delta = 1) override;

virtual LayoutRect scrollIntoView(

const LayoutRect& rectInContent,

const ScrollAlignment& alignX,