Source/web/ChromeClientImpl.cpp - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tests !!! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index b47a0c603ad6b2191718e9df1ba6be63a956af7a..dc81e2ff833819d0104ade20d016d0bd220462e9 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -292,6 +292,14 @@ void ChromeClientImpl::show(NavigationPolicy navigationPolicy)

m_webView->client()->show(policy);

}

+void ChromeClientImpl::didOverscroll(FloatSize& unusedDelta, FloatSize& accumulatedRootOverScroll, FloatPoint& position, FloatSize& velocity)

+ if (!m_webView->client())

+ return;

+ m_webView->client()->didOverscroll(unusedDelta, accumulatedRootOverScroll, position, velocity);

void ChromeClientImpl::setToolbarsVisible(bool value)

{

m_windowFeatures.toolBarVisible = value;