Source/web/ChromeClientImpl.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments of aelias Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index c021c47b7f86e55e79cf39b3a9d887584ccda8f1..3583fb6e135fe5b4f04785d72bf3ce0f621e80a7 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -81,6 +81,7 @@ public:

virtual Page* createWindow(

LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ShouldSendReferrer) override;

virtual void show(NavigationPolicy) override;

+ virtual void didOverScrollOnMainThread(FloatPoint&, FloatPoint&, FloatPoint&, FloatPoint&) override;

majidvp 2015/05/05 15:29:14 Please use 'Overscroll' for consistency with CC co

virtual void setToolbarsVisible(bool) override;

virtual bool toolbarsVisible() override;

virtual void setStatusbarVisible(bool) override;