Source/core/loader/EmptyClients.h - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.h

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments of aelias Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/EmptyClients.h

diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h

index 9cf5195043a9ea355cf5c792c843b1453314b990..c30dd0c1806d6a2a450790ad0f31a4a36ed916b9 100644

--- a/Source/core/loader/EmptyClients.h

+++ b/Source/core/loader/EmptyClients.h

@@ -39,6 +39,7 @@

#include "core/page/Page.h"

#include "core/page/SpellCheckerClient.h"

#include "platform/DragImage.h"

+#include "platform/geometry/FloatPoint.h"

#include "platform/geometry/IntRect.h"

#include "platform/heap/Handle.h"

#include "platform/network/ResourceError.h"

@@ -85,6 +86,8 @@ public:

virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ShouldSendReferrer) override { return 0; }

virtual void show(NavigationPolicy) override { }

+ virtual void didOverScrollOnMainThread(FloatPoint&, FloatPoint&, FloatPoint&, FloatPoint&) override { }

virtual void setToolbarsVisible(bool) override { }

virtual bool toolbarsVisible() override { return false; }