Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed review comments of bokan Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 ASSERT(frame->document()); 292 ASSERT(frame->document());
293 Fullscreen::fullyExitFullscreen(*frame->document()); 293 Fullscreen::fullyExitFullscreen(*frame->document());
294 294
295 WebViewImpl* newView = toWebViewImpl( 295 WebViewImpl* newView = toWebViewImpl(
296 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shoul dSendReferrer == NeverSendReferrer)); 296 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shoul dSendReferrer == NeverSendReferrer));
297 if (!newView) 297 if (!newView)
298 return nullptr; 298 return nullptr;
299 return newView->page(); 299 return newView->page();
300 } 300 }
301 301
302 void ChromeClientImpl::didOverscroll(const FloatSize& unusedDelta, const FloatSi ze& accumulatedRootOverScroll, const FloatPoint& position, const FloatSize& velo city)
303 {
304 if (!m_webView->client())
305 return;
306
307 m_webView->client()->didOverscroll(unusedDelta, accumulatedRootOverScroll, p osition, velocity);
308 }
309
302 void ChromeClientImpl::show(NavigationPolicy navigationPolicy) 310 void ChromeClientImpl::show(NavigationPolicy navigationPolicy)
303 { 311 {
304 if (m_webView->client()) 312 if (m_webView->client())
305 m_webView->client()->show(effectiveNavigationPolicy(navigationPolicy, m_ windowFeatures)); 313 m_webView->client()->show(effectiveNavigationPolicy(navigationPolicy, m_ windowFeatures));
306 } 314 }
307 315
308 void ChromeClientImpl::setToolbarsVisible(bool value) 316 void ChromeClientImpl::setToolbarsVisible(bool value)
309 { 317 {
310 m_windowFeatures.toolBarVisible = value; 318 m_windowFeatures.toolBarVisible = value;
311 } 319 }
(...skipping 628 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 } 948 }
941 949
942 void ChromeClientImpl::notifyPopupOpeningObservers() const 950 void ChromeClientImpl::notifyPopupOpeningObservers() const
943 { 951 {
944 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers); 952 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers);
945 for (const auto& observer : observers) 953 for (const auto& observer : observers)
946 observer->willOpenPopup(); 954 observer->willOpenPopup();
947 } 955 }
948 956
949 } // namespace blink 957 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698