OverscrollGlow for mainThread-{BLINK CHANGES}

Source/platform/scroll/ScrollTypes.h

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 175 matching lines @@
         , unusedScrollDelta(0) { }
     ScrollResultOneDimensional(bool didScroll, float unusedScrollDelta)
         : didScroll(didScroll)
         , unusedScrollDelta(unusedScrollDelta) { }
 
     bool didScroll;
     float unusedScrollDelta;
 };
 
 struct ScrollResult {
     explicit ScrollResult(bool didScroll)

[majidvp, 2015/06/01 15:58:29]

The 'true' value for didScroll is ambiguous in terms of didScrollX and
didScrollY but 'false' is not. So I think this constructor should be replaced
with a default constructor that takes not argument and initializes didScrollX
and didScrollY both to false.

All call sites for this constructor pass false so they can be replaced easily.

[MuVen, 2015/06/02 09:04:00]

Done.

         : didScroll(didScroll)
         , unusedScrollDeltaX(0)
         , unusedScrollDeltaY(0) { }
     ScrollResult(bool didScroll, float unusedScrollDeltaX, float unusedScrollDeltaY)

[majidvp, 2015/06/01 15:58:29]

Please get rid of this constructor.

[MuVen, 2015/06/02 09:04:00]

Done.

         : didScroll(didScroll)
         , unusedScrollDeltaX(unusedScrollDeltaX)
         , unusedScrollDeltaY(unusedScrollDeltaY) { }
+    ScrollResult(bool didScrollX, bool didScrollY, float unusedScrollDeltaX, float unusedScrollDeltaY)
+        : didScrollX(didScrollX)
+        , didScrollY(didScrollY)
+        , unusedScrollDeltaX(unusedScrollDeltaX)
+        , unusedScrollDeltaY(unusedScrollDeltaY) { }
 
     bool didScroll;

[majidvp, 2015/06/01 15:58:29]

We should not keep didScroll around anymore as it can lead to the object being
in an inconsistent internal state. Please get rid of it and replace with an
inline:

bool didScroll() { return didScrollX || didScrollY; }

[MuVen, 2015/06/02 09:04:00]

Done.

+    bool didScrollX;
+    bool didScrollY;
     float unusedScrollDeltaX;
     float unusedScrollDeltaY;
 };
 
 typedef unsigned ScrollbarControlPartMask;
 
 }
 
 #endif