Source/web/tests/data/overscroll/overscroll.html - Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES}

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/overscroll/overscroll.html

Issue 1056983004: OverscrollGlow for mainThread-{BLINK CHANGES} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>
	majidvp 2015/05/29 19:14:19 The fact the this document is not even scrollable The fact the this document is not even scrollable tells me that indeed the test is not actually testing the reset logic. MuVen 2015/06/01 13:29:26 Current reset logic fixes this. I think this needs Current reset logic fixes this. I think this needs modification once no overflow on nonscrollable axes patch landes. I shall modify this along that patch. majidvp 2015/06/01 15:58:29 I don't think you can test the reset logic with th Show quoted text On 2015/06/01 13:29:26, MuVen wrote: > Current reset logic fixes this. I think this needs modification once > no overflow on nonscrollable axes patch landes. I shall modify this > along that patch. I don't think you can test the reset logic with this not being scrollable. MuVen 2015/06/02 09:04:00 modified, testcase. Done. Show quoted text On 2015/06/01 15:58:29, majidvp wrote: > On 2015/06/01 13:29:26, MuVen wrote: > > Current reset logic fixes this. I think this needs modification once > > no overflow on nonscrollable axes patch landes. I shall modify this > > along that patch. > > I don't think you can test the reset logic with this not being scrollable. modified, testcase. Done.
4 <p>a

5 </body>	4 </body>

6 </html>	5 </html>

	6

OLD	NEW