Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105693009: Move insertAdjacentHTML to Element (Closed)

Created:
7 years ago by davve
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive, Erik Dahlström (inactive)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move insertAdjacentHTML to Element http://domparsing.spec.whatwg.org/#insertadjacenthtml() Remove some stale comments in the process, now that we actually have a specification. Also, IE doesn't seem to allow parsing in the void (e.g. "afterEnd" on a detached element) anymore, at least not for insertAdjacentHTML. BUG=326964 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163529

Patch Set 1 #

Patch Set 2 : Correct base. Should not include patches it depends on. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -92 lines) Patch
M LayoutTests/fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dynamic/insertAdjacentHTML-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/dynamic/insertAdjacentHTML-svg.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dynamic/insertAdjacentHTML-svg-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 chunks +0 lines, -71 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
Ed suggested/hinted at this move in https://codereview.chromium.org/44333002/#msg2 Depends on https://codereview.chromium.org/109273003/ and https://codereview.chromium.org/110383002/ which are issues ...
7 years ago (2013-12-09 16:09:59 UTC) #1
abarth-chromium
lgtm
7 years ago (2013-12-09 17:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/105693009/20001
7 years ago (2013-12-10 09:56:55 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-10 11:32:34 UTC) #4
Message was sent while issue was closed. 
Change committed as 163529

Powered by Google App Engine
This is Rietveld 408576698