Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 105693002: Generate a bit less code to handle failed arity checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 13 matching lines...) Expand all
24 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 24 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
25 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 25 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
27 * OF THE POSSIBILITY OF SUCH DAMAGE. 27 * OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 #include "config.h" 30 #include "config.h"
31 #include "V8TextTrackCue.h" 31 #include "V8TextTrackCue.h"
32 32
33 #include "V8VTTCue.h" 33 #include "V8VTTCue.h"
34
35 #include "bindings/v8/ExceptionMessages.h"
36 #include "bindings/v8/ExceptionState.h"
34 #include "core/frame/UseCounter.h" 37 #include "core/frame/UseCounter.h"
35 38
36 namespace WebCore { 39 namespace WebCore {
37 40
38 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate) 41 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate)
39 { 42 {
40 return toV8(toVTTCue(impl), creationContext, isolate); 43 return toV8(toVTTCue(impl), creationContext, isolate);
41 } 44 }
42 45
43 // Custom constructor to make new TextTrackCue(...) return a VTTCue. This is leg acy 46 // Custom constructor to make new TextTrackCue(...) return a VTTCue. This is leg acy
44 // compat, not per spec, and should be removed at the earliest opportunity. 47 // compat, not per spec, and should be removed at the earliest opportunity.
45 void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & info) 48 void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & info)
46 { 49 {
50 ExceptionState exceptionState(ExceptionState::ConstructionContext, "TextTrac kCue", info.Holder(), info.GetIsolate());
47 if (UNLIKELY(info.Length() < 3)) { 51 if (UNLIKELY(info.Length() < 3)) {
48 throwTypeError(ExceptionMessages::failedToConstruct("TextTrackCue", Exce ptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate()); 52 exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(3, i nfo.Length()));
53 exceptionState.throwIfNeeded();
49 return; 54 return;
50 } 55 }
51 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( ))); 56 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( )));
52 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) ); 57 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) );
53 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]); 58 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);
54 59
55 Document& document = *toDocument(getExecutionContext()); 60 Document& document = *toDocument(getExecutionContext());
56 UseCounter::count(document, UseCounter::TextTrackCueConstructor); 61 UseCounter::count(document, UseCounter::TextTrackCueConstructor);
57 VTTCue* impl = VTTCue::create(document, startTime, endTime, text).leakRef(); 62 VTTCue* impl = VTTCue::create(document, startTime, endTime, text).leakRef();
58 v8::Handle<v8::Object> wrapper = wrap(impl, info.Holder(), info.GetIsolate() ); 63 v8::Handle<v8::Object> wrapper = wrap(impl, info.Holder(), info.GetIsolate() );
59 info.GetReturnValue().Set(wrapper); 64 info.GetReturnValue().Set(wrapper);
60 } 65 }
61 66
62 } // namespace WebCore 67 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8SVGLengthCustom.cpp ('k') | Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698