Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/bindings/v8/custom/V8CryptoCustom.cpp

Issue 105693002: Generate a bit less code to handle failed arity checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 #include "modules/crypto/Crypto.h" 34 #include "modules/crypto/Crypto.h"
35 #include "wtf/ArrayBufferView.h" 35 #include "wtf/ArrayBufferView.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 // This custom binding is shared by V8WorkerCrypto. As such: 39 // This custom binding is shared by V8WorkerCrypto. As such:
40 // * Do not call V8Crypto::toNative() 40 // * Do not call V8Crypto::toNative()
41 // * Must be threadsafe 41 // * Must be threadsafe
42 void V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info) 42 void V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info)
43 { 43 {
44 ExceptionState exceptionState(ExceptionState::ExecutionContext, "getRandomVa lues", "Crypto", info.Holder(), info.GetIsolate());
44 if (info.Length() < 1) { 45 if (info.Length() < 1) {
45 throwTypeError(ExceptionMessages::failedToExecute("getRandomValues", "Cr ypto", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsolate ()); 46 exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, i nfo.Length()));
47 exceptionState.throwIfNeeded();
46 return; 48 return;
47 } 49 }
48 50
49 v8::Handle<v8::Value> buffer = info[0]; 51 v8::Handle<v8::Value> buffer = info[0];
50 if (!V8ArrayBufferView::hasInstance(buffer, info.GetIsolate(), worldType(inf o.GetIsolate()))) { 52 if (!V8ArrayBufferView::hasInstance(buffer, info.GetIsolate(), worldType(inf o.GetIsolate()))) {
51 throwTypeError("First argument is not an ArrayBufferView", info.GetIsola te()); 53 exceptionState.throwTypeError("First argument is not an ArrayBufferView" );
52 return; 54 } else {
55 ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handl e<v8::Object>::Cast(buffer));
56 ASSERT(arrayBufferView);
57
58 Crypto::getRandomValues(arrayBufferView, exceptionState);
53 } 59 }
54 60
55 ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handle<v8 ::Object>::Cast(buffer));
56 ASSERT(arrayBufferView);
57
58 ExceptionState exceptionState(ExceptionState::ExecutionContext, "getRandomVa lues", "Crypto", info.Holder(), info.GetIsolate());
59 Crypto::getRandomValues(arrayBufferView, exceptionState);
60
61 if (exceptionState.throwIfNeeded()) 61 if (exceptionState.throwIfNeeded())
62 return; 62 return;
63 63
64 v8SetReturnValue(info, buffer); 64 v8SetReturnValue(info, buffer);
65 } 65 }
66 66
67 } // namespace WebCore 67 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/custom/V8MutationObserverCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698