Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1056913003: JSEntryTrampoline: check for stack space before pushing arguments (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev, dusmil.imgtec, michael_dawson, chunyang.dai
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

JSEntryTrampoline: check for stack space before pushing arguments Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself. BUG=chromium:469768 LOG=y Committed: https://crrev.com/146598f44a1efd0f942745abfd6c08a073972c01 Cr-Commit-Position: refs/heads/master@{#27614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -123 lines) Patch
M src/arm/builtins-arm.cc View 5 chunks +43 lines, -25 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 5 chunks +51 lines, -33 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +48 lines, -34 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +50 lines, -31 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-469768.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
lgtm
5 years, 8 months ago (2015-04-07 08:50:29 UTC) #2
Jakob Kummerow
Yang, thanks for the review. Note for other architectures: Generate_CheckStackOverflow was mostly just moved, and ...
5 years, 8 months ago (2015-04-07 08:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056913003/1
5 years, 8 months ago (2015-04-07 08:54:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 09:13:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 09:13:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/146598f44a1efd0f942745abfd6c08a073972c01
Cr-Commit-Position: refs/heads/master@{#27614}

Powered by Google App Engine
This is Rietveld 408576698