Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1056913002: Add testRunner.insertStyleSheet for testing style sheet injection. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add testRunner.insertStyleSheet for testing style sheet injection. testRunner.injectStyleSheet uses a different code path from the only way to inject stylesheets in Chrome (extensions) now that user stylesheets are no longer supported. In addition, the Blink implementation is not friendly to OOPI, since it expects all frames to be in one process. Tying it to WebLocalFrame::frameForCurrentContext() is a bit awkward, but all the TestRunner plumbing currently expects to work on a per-WebView basis, and changing it is rather complicated. Once a TestRunner can be associated with a WebFrame, it won't need to be tied to the current context and the corresponding layout test can be cleaned up. BUG= Committed: https://crrev.com/9000dbd4ec56fc35123ae257c51981697a1c8e28 Cr-Commit-Position: refs/heads/master@{#323646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Context: this is needed to unblock https://codereview.chromium.org/1058723002 from landing, which will unblock the removal of ...
5 years, 8 months ago (2015-04-02 15:55:11 UTC) #2
pfeldman
On 2015/04/02 15:55:11, dcheng wrote: > Context: this is needed to unblock https://codereview.chromium.org/1058723002 > from ...
5 years, 8 months ago (2015-04-02 18:46:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056913002/1
5 years, 8 months ago (2015-04-02 19:28:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 05:39:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:33:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9000dbd4ec56fc35123ae257c51981697a1c8e28
Cr-Commit-Position: refs/heads/master@{#323646}

Powered by Google App Engine
This is Rietveld 408576698