Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1056903002: Enable dart2js hints test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index 4dd1675da55c067884f77cccfd494ec1484d6a26..973b12d5ec68ec467a358a9801991ffe1552a3c6 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -1137,21 +1137,19 @@ int main() {
}
test_perform_dart2js() {
- // TODO(scheglov) There is a bug - we need to finish building
- // TypeProvider hierarchies before validating "expr is CoreType".
-// Source source = _newSource('/test.dart', '''
-//main(p) {
-// if (p is double) {
-// print('double');
-// }
-//}
-//''');
-// LibraryUnitTarget target = new LibraryUnitTarget(source, source);
-// _computeResult(target, HINTS);
-// expect(task, new isInstanceOf<GenerateHintsTask>());
-// // validate
-// _fillErrorListener(HINTS);
-// errorListener.assertErrorsWithCodes(<ErrorCode>[HintCode.IS_DOUBLE]);
+ Source source = _newSource('/test.dart', '''
+main(p) {
+ if (p is double) {
+ print('double');
+ }
+}
+''');
+ LibraryUnitTarget target = new LibraryUnitTarget(source, source);
+ _computeResult(target, HINTS);
+ expect(task, new isInstanceOf<GenerateHintsTask>());
+ // validate
+ _fillErrorListener(HINTS);
+ errorListener.assertErrorsWithCodes(<ErrorCode>[HintCode.IS_DOUBLE]);
}
test_perform_deadCode() {
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698