Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1056893003: Add setNeedsLayoutAndFullPaintInvalidation to WebWidget. (Closed)

Created:
5 years, 8 months ago by Stephen Chennney
Modified:
5 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, dglazkov+blink, tommycli
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add setNeedsLayoutAndFullPaintInvalidation to WebWidget. Plugins need to invalidate layout on their WebView when content changes due to factors that the view is not otherwise aware of. Here we add a method to set the various bits necessary to cause layout to perform work at the next opportunity. In the current code, this will be used to force paint invalidation to be issued on the plugin when placeholder content is loaded. BUG=472348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193056

Patch Set 1 #

Patch Set 2 : Checking for null pointers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M public/web/WebWidget.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Stephen Chennney
This lays the groundwork for a fix to the plugin paint invalidation problem. I believe ...
5 years, 8 months ago (2015-04-02 19:06:39 UTC) #2
Stephen Chennney
+tommycli
5 years, 8 months ago (2015-04-02 19:07:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056893003/20001
5 years, 8 months ago (2015-04-02 19:08:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30414)
5 years, 8 months ago (2015-04-02 19:19:06 UTC) #7
pdr.
On 2015/04/02 at 19:19:06, commit-bot wrote: > Try jobs failed on following builders: > blink_presubmit ...
5 years, 8 months ago (2015-04-02 19:45:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056893003/20001
5 years, 8 months ago (2015-04-02 20:00:31 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 00:12:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193056

Powered by Google App Engine
This is Rietveld 408576698