Rearranged intrinsic declarations according to their implementations.

Rearranged intrinsic declarations according to their implementations.

Now every FOR_EACH_INTRINSIC_FOO sub-macro corresponds to a
src/runtime/runtime-FOO.cc file, even the order of runtime functions
within that file has been preserved in the corresponding macro, thanks
to some eye-hurting for/clang/sed/grep madness. ;-)

BUG=v8:3947
LOG=n

Committed: https://crrev.com/cfe76e82d9899bc061cd1859eda1605451980fb3
Cr-Commit-Position: refs/heads/master@{#27609}

[Sven Panne, 2015-04-02 11:05:46]

svenpanne@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-04-02 11:36:24]

LGTM. I like it. Please also coordinate with Yang whether he agrees.

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:18: //      question decides).
nit: OCD kicking in, closing bracket is never opened. :)

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:20: // * IntrinsicTypes are Runtime::RUNTIME and 
Runtime::INLINE, respectively.
nit: OCD kicking in, two white-spaces after "and".

[Sven Panne, 2015-04-02 12:47:32]

svenpanne@chromium.org changed reviewers:
+ yangguo@chromium.org

[Sven Panne, 2015-04-02 12:47:33]

Feedback addressed + changed Yang from CC: to a reviewer.

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:18: //      question decides).
On 2015/04/02 11:36:24, Michael Starzinger wrote:
> nit: OCD kicking in, closing bracket is never opened. :)

Done.

https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
src/runtime/runtime.h:20: // * IntrinsicTypes are Runtime::RUNTIME and 
Runtime::INLINE, respectively.
On 2015/04/02 11:36:24, Michael Starzinger wrote:
> nit: OCD kicking in, two white-spaces after "and".

Done.

[Yang, 2015-04-02 18:50:32]

On 2015/04/02 12:47:33, Sven Panne wrote:
> Feedback addressed + changed Yang from CC: to a reviewer.
> 
> https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h
> File src/runtime/runtime.h (right):
> 
>
https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
> src/runtime/runtime.h:18: //      question decides).
> On 2015/04/02 11:36:24, Michael Starzinger wrote:
> > nit: OCD kicking in, closing bracket is never opened. :)
> 
> Done.
> 
>
https://codereview.chromium.org/1056863002/diff/1/src/runtime/runtime.h#newco...
> src/runtime/runtime.h:20: // * IntrinsicTypes are Runtime::RUNTIME and 
> Runtime::INLINE, respectively.
> On 2015/04/02 11:36:24, Michael Starzinger wrote:
> > nit: OCD kicking in, two white-spaces after "and".
> 
> Done.

Lgtm! Would it make sense to have a presubmit script policing this ordering?

[Sven Panne, 2015-04-07 06:49:59]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-04-07 06:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1056863002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-04-07 06:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056863002/40001

[commit-bot: I haz the power, 2015-04-07 07:12:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 07:12:58]

Patchset 3 (id:??) landed as
https://crrev.com/cfe76e82d9899bc061cd1859eda1605451980fb3
Cr-Commit-Position: refs/heads/master@{#27609}

[Sven Panne, 2015-04-07 07:21:21]

On 2015/04/02 18:50:32, Yang wrote:
> Lgtm! Would it make sense to have a presubmit script policing this ordering?

Just for the record: We discussed this briefly offline and decided to have no
presubmit check. The reason is that due to creative use of 2nd order macros, one
would need heavy clang/grep/sed trickery to check this, and the cost/benefit
ratio seems to be a bit low.