Issue 105683004: Fix a crash in the NPAPI plugin code which occurs after we call the plugins window proc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105683004: Fix a crash in the NPAPI plugin code which occurs after we call the plugins window proc. (Closed)

Created:
7 years ago by ananta

Modified:
7 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix a crash in the NPAPI plugin code which occurs after we call the plugins window proc. The crash occurs while dereferencing the WebPluginDelegateImpl instance after the CallWindowProc call. It appears that the plugin instance was destroyed in this context. Attempted fix is to check if the HWND is still valid before dereferencing the instance. Theory being that if the instance is destroyed, the HWND will also be destroyed via WindowedDestroyWindow BUG=276339 R=jam@chromium.org, jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239040

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	content/child/npapi/webplugin_delegate_impl_win.cc	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r239040 (presubmit successful).

Expand Messages | Collapse Messages