Issue 1056813002: [Fetch] Request.clone() should reflect body consumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056813002: [Fetch] Request.clone() should reflect body consumption. (Closed)

Created:
5 years, 8 months ago by yhirano

Modified:
5 years, 8 months ago

Reviewers:
horo

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@body-used

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

[Fetch] Request.clone() should reflect body consumption. As discussed at [1], req.clone() should generate a Request object having body that was unconsumed at the calling time. 1: https://github.com/slightlyoff/ServiceWorker/issues/452 This CL also adds similar tests for Response. BUG=472931 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193073

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
M	LayoutTests/http/tests/fetch/script-tests/request.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/fetch/script-tests/response.js	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	Source/modules/fetch/Request.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

yhirano

This CL depends on https://codereview.chromium.org/1049983003/.

5 years, 8 months ago (2015-04-02 05:18:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056813002/20001

5 years, 8 months ago (2015-04-03 00:10:47 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 04:22:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193073