chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 1056793006: [Docking] Persists docked state on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1056793006: [Docking] Persists docked state on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [Docking] Makes docked state persistent on Chrome OS Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 3bcf3db1f36819a2804ad06844a2ba1d22171df6..d9f7196cd6e8ddac5a00fd59a14f77798265c3c8 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -184,6 +184,7 @@ void AssignOptionalValue(const scoped_ptr<T>& source,

ui::WindowShowState ConvertToWindowShowState(windows::WindowState state) {

switch (state) {

case windows::WINDOW_STATE_NORMAL:

+ case windows::WINDOW_STATE_DOCKED:

return ui::SHOW_STATE_NORMAL;

case windows::WINDOW_STATE_MINIMIZED:

return ui::SHOW_STATE_MINIMIZED;

@@ -528,6 +529,7 @@ bool WindowsCreateFunction::RunSync() {

if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) {

AppWindow::CreateParams create_params;

create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL;

+ create_params.window_key = extension_id;

create_params.window_spec.bounds = window_bounds;

create_params.focused = saw_focus_key && focused;

AppWindow* app_window = new AppWindow(