Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1056793006: [Docking] Persists docked state on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Docking] Makes docked state persistent on Chrome OS (comments) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs_api.h" 5 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 void AssignOptionalValue(const scoped_ptr<T>& source, 177 void AssignOptionalValue(const scoped_ptr<T>& source,
178 scoped_ptr<T>& destination) { 178 scoped_ptr<T>& destination) {
179 if (source.get()) { 179 if (source.get()) {
180 destination.reset(new T(*source.get())); 180 destination.reset(new T(*source.get()));
181 } 181 }
182 } 182 }
183 183
184 ui::WindowShowState ConvertToWindowShowState(windows::WindowState state) { 184 ui::WindowShowState ConvertToWindowShowState(windows::WindowState state) {
185 switch (state) { 185 switch (state) {
186 case windows::WINDOW_STATE_NORMAL: 186 case windows::WINDOW_STATE_NORMAL:
187 case windows::WINDOW_STATE_DOCKED:
187 return ui::SHOW_STATE_NORMAL; 188 return ui::SHOW_STATE_NORMAL;
188 case windows::WINDOW_STATE_MINIMIZED: 189 case windows::WINDOW_STATE_MINIMIZED:
189 return ui::SHOW_STATE_MINIMIZED; 190 return ui::SHOW_STATE_MINIMIZED;
190 case windows::WINDOW_STATE_MAXIMIZED: 191 case windows::WINDOW_STATE_MAXIMIZED:
191 return ui::SHOW_STATE_MAXIMIZED; 192 return ui::SHOW_STATE_MAXIMIZED;
192 case windows::WINDOW_STATE_FULLSCREEN: 193 case windows::WINDOW_STATE_FULLSCREEN:
193 return ui::SHOW_STATE_FULLSCREEN; 194 return ui::SHOW_STATE_FULLSCREEN;
194 case windows::WINDOW_STATE_NONE: 195 case windows::WINDOW_STATE_NONE:
195 return ui::SHOW_STATE_DEFAULT; 196 return ui::SHOW_STATE_DEFAULT;
196 } 197 }
(...skipping 16 matching lines...) Expand all
213 case windows::WINDOW_STATE_MINIMIZED: 214 case windows::WINDOW_STATE_MINIMIZED:
214 // If minimised, default focused state should be unfocused. 215 // If minimised, default focused state should be unfocused.
215 return !(create_data->focused && *create_data->focused) && !has_bound && 216 return !(create_data->focused && *create_data->focused) && !has_bound &&
216 !is_panel; 217 !is_panel;
217 case windows::WINDOW_STATE_MAXIMIZED: 218 case windows::WINDOW_STATE_MAXIMIZED:
218 case windows::WINDOW_STATE_FULLSCREEN: 219 case windows::WINDOW_STATE_FULLSCREEN:
219 // If maximised/fullscreen, default focused state should be focused. 220 // If maximised/fullscreen, default focused state should be focused.
220 return !(create_data->focused && !*create_data->focused) && !has_bound && 221 return !(create_data->focused && !*create_data->focused) && !has_bound &&
221 !is_panel; 222 !is_panel;
222 case windows::WINDOW_STATE_NORMAL: 223 case windows::WINDOW_STATE_NORMAL:
224 case windows::WINDOW_STATE_DOCKED:
223 case windows::WINDOW_STATE_NONE: 225 case windows::WINDOW_STATE_NONE:
224 return true; 226 return true;
225 } 227 }
226 NOTREACHED(); 228 NOTREACHED();
227 return true; 229 return true;
228 } 230 }
229 231
230 } // namespace 232 } // namespace
231 233
232 void ZoomModeToZoomSettings(ZoomController::ZoomMode zoom_mode, 234 void ZoomModeToZoomSettings(ZoomController::ZoomMode zoom_mode,
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 } 557 }
556 558
557 if (create_panel) { 559 if (create_panel) {
558 if (urls.empty()) 560 if (urls.empty())
559 urls.push_back(GURL(chrome::kChromeUINewTabURL)); 561 urls.push_back(GURL(chrome::kChromeUINewTabURL));
560 562
561 #if defined(USE_ASH) 563 #if defined(USE_ASH)
562 if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) { 564 if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) {
563 AppWindow::CreateParams create_params; 565 AppWindow::CreateParams create_params;
564 create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL; 566 create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL;
567 create_params.window_key = extension_id;
565 create_params.window_spec.bounds = window_bounds; 568 create_params.window_spec.bounds = window_bounds;
566 create_params.focused = saw_focus_key && focused; 569 create_params.focused = saw_focus_key && focused;
567 AppWindow* app_window = new AppWindow( 570 AppWindow* app_window = new AppWindow(
568 window_profile, 571 window_profile,
569 new ChromeAppDelegate(make_scoped_ptr(new ScopedKeepAlive)), 572 new ChromeAppDelegate(make_scoped_ptr(new ScopedKeepAlive)),
570 extension()); 573 extension());
571 AshPanelContents* ash_panel_contents = new AshPanelContents(app_window); 574 AshPanelContents* ash_panel_contents = new AshPanelContents(app_window);
572 app_window->Init(urls[0], ash_panel_contents, create_params); 575 app_window->Init(urls[0], ash_panel_contents, create_params);
573 SetResult(ash_panel_contents->GetExtensionWindowController() 576 SetResult(ash_panel_contents->GetExtensionWindowController()
574 ->CreateWindowValueWithTabs(extension())); 577 ->CreateWindowValueWithTabs(extension()));
(...skipping 1427 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 ZoomModeToZoomSettings(zoom_mode, &zoom_settings); 2005 ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
2003 zoom_settings.default_zoom_factor.reset(new double( 2006 zoom_settings.default_zoom_factor.reset(new double(
2004 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel()))); 2007 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
2005 2008
2006 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings); 2009 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
2007 SendResponse(true); 2010 SendResponse(true);
2008 return true; 2011 return true;
2009 } 2012 }
2010 2013
2011 } // namespace extensions 2014 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_api.cc ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698