Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1056783002: [Fetch] Request constructor should reflect body consumption. (Closed)

Created:
5 years, 8 months ago by yhirano
Modified:
5 years, 8 months ago
Reviewers:
horo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@body-used
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Request constructor should reflect body consumption. As discussed at [1], new Request(req) should generate a Request object having body that was unconsumed at the calling time. 1: https://github.com/slightlyoff/ServiceWorker/issues/452 BUG=472931 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193069

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/request.js View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/modules/fetch/Request.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056783002/1
5 years, 8 months ago (2015-04-02 02:35:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/40538)
5 years, 8 months ago (2015-04-02 02:42:14 UTC) #4
yhirano
This CL depends on https://codereview.chromium.org/1049983003/.
5 years, 8 months ago (2015-04-02 04:32:26 UTC) #6
horo
lgtm
5 years, 8 months ago (2015-04-02 07:19:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056783002/20001
5 years, 8 months ago (2015-04-03 00:10:44 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 03:49:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193069

Powered by Google App Engine
This is Rietveld 408576698