Blacklist desk_wikipedia pdf on Valgrind bots

Blacklist desk_wikipedia pdf on Valgrind bots

BUG=skia:3506
Committed: https://skia.googlesource.com/skia/+/22ecae88eec772be86da34015090a2eb649b9511

[borenet, 2015-04-13 20:05:25]

borenet@google.com changed reviewers:
+ mtklein@google.com

[borenet, 2015-04-13 20:05:26]

https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json
File tools/dm_flags.json (right):

https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json#newcode95
tools/dm_flags.json:95: "image",
I think most of these are because someone forgot to run the test after adding
these blacklists.

[mtklein, 2015-04-13 20:10:27]

lgtm

On 2015/04/13 20:05:26, borenet wrote:
> https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json
> File tools/dm_flags.json (right):
> 
>
https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json#newcode95
> tools/dm_flags.json:95: "image",
> I think most of these are because someone forgot to run the test after adding
> these blacklists.

Tangentially, can we make it run from the presubmit if those files change?

[borenet, 2015-04-13 20:14:42]

On 2015/04/13 20:10:27, mtklein wrote:
> lgtm
> 
> On 2015/04/13 20:05:26, borenet wrote:
> > https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json
> > File tools/dm_flags.json (right):
> > 
> >
>
https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json#newcode95
> > tools/dm_flags.json:95: "image",
> > I think most of these are because someone forgot to run the test after
adding
> > these blacklists.
> 
> Tangentially, can we make it run from the presubmit if those files change?

Is there a mode which fails if the generated JSON differs from the checked-in
file?  Like, can we change "dm_flags.py test" to fail if the generated JSON
differs from the checked in version, and add "dm_flags.py train" to write the
JSON file?  Then we could just run "dm_flags.py test" in presubmit.

[borenet, 2015-04-13 20:14:53]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-04-13 20:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763004/1

[mtklein, 2015-04-13 20:16:16]

On 2015/04/13 20:14:42, borenet wrote:
> On 2015/04/13 20:10:27, mtklein wrote:
> > lgtm
> > 
> > On 2015/04/13 20:05:26, borenet wrote:
> > > https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json
> > > File tools/dm_flags.json (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1056763004/diff/1/tools/dm_flags.json#newcode95
> > > tools/dm_flags.json:95: "image",
> > > I think most of these are because someone forgot to run the test after
> adding
> > > these blacklists.
> > 
> > Tangentially, can we make it run from the presubmit if those files change?
> 
> Is there a mode which fails if the generated JSON differs from the checked-in
> file?  Like, can we change "dm_flags.py test" to fail if the generated JSON
> differs from the checked in version, and add "dm_flags.py train" to write the
> JSON file?  Then we could just run "dm_flags.py test" in presubmit.

We can certainly make it work that way.

[commit-bot: I haz the power, 2015-04-13 20:29:30]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/22ecae88eec772be86da34015090a2eb649b9511