Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(40)

Issue 1056743002: Improve whitespace matching for encoding Android page info popup URLs. (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve whitespace matching for encoding Android page info popup URLs. Use the built-in Character.isSpaceChar function to determine what characters should be encoded, which is more accurate than the home-made matcher used previously. BUG=466351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
tsergeant
tedchoc@, can you please take a look at this one too?
4 years, 4 months ago (2015-04-02 02:00:03 UTC) #2
Ted C
4 years, 4 months ago (2015-04-02 16:59:37 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698