Issue 1056743002: Improve whitespace matching for encoding Android page info popup URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056743002: Improve whitespace matching for encoding Android page info popup URLs. (Closed)

Created:
5 years, 8 months ago by tsergeant

Modified:
5 years, 8 months ago

Reviewers:
Ted C

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Matt Giuca

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve whitespace matching for encoding Android page info popup URLs. Use the built-in Character.isSpaceChar function to determine what characters should be encoded, which is more accurate than the home-made matcher used previously. BUG=466351

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java	View		2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages