Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1056723002: DevTools: [CodeMirror] add Cmd-Backspace for the mac text editor (Closed)

Created:
5 years, 8 months ago by jlast
Modified:
5 years, 8 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirror] add Cmd-Backspace for the mac text editor Deletes the characters to the left of the line. I did not update the pc or common shortcuts because there is an inconsistency with PC. I'm not sure if that's something we want to address here. BUG=472882 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
jlast: I assume you were about to send it?
5 years, 8 months ago (2015-04-02 10:50:00 UTC) #2
lushnikov
lgtm. nit: The title of the issue should start with the general "DevTools:" prefix. (I've ...
5 years, 8 months ago (2015-04-02 12:36:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056723002/1
5 years, 8 months ago (2015-04-02 12:37:29 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 14:23:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193037

Powered by Google App Engine
This is Rietveld 408576698