Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1056663005: X87: Fix the bug in CompareIC_GenerateNumber (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the bug in CompareIC_GenerateNumber for X87 platform. The original code will not update the IC info if one of parameter is SMI. It Can not handle Number + Smi. BUG= Committed: https://crrev.com/845154a896ee7231ec016b6549fb755dfdc496c3 Cr-Commit-Position: refs/heads/master@{#27583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-02 09:41:05 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-02 09:53:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056663005/1
5 years, 8 months ago (2015-04-02 09:53:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 10:17:02 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 10:17:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/845154a896ee7231ec016b6549fb755dfdc496c3
Cr-Commit-Position: refs/heads/master@{#27583}

Powered by Google App Engine
This is Rietveld 408576698