Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1056663002: s/Node/UINode/ in the tests (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Issue 1043283003 changed the framework class names but I missed the test. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d8b4f89983062d1f08401549f6bd15d9086359ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/tests/framework/basic.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
ojan
lgtm Please fix the change description to actually say something. In this case, say which ...
5 years, 8 months ago (2015-04-01 20:45:21 UTC) #6
Hixie
5 years, 8 months ago (2015-04-01 20:49:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8b4f89983062d1f08401549f6bd15d9086359ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698