Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1056613002: reduce diff churn due to server_mode test (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

reduce diff churn due to server_mode test essentially verify the expected HTML in the test this tripped on an interesting issue, we have two ways of computing MD5 hashes that produce different answers. I left that as a TODO. R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/dd9ab2af960906485fb0df9de538bcd809d3f58e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -65 lines) Patch
D test/codegen/expect/server_mode/dir/html_input_a.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/codegen/expect/server_mode/dir/html_input_b.js View 1 chunk +0 lines, -5 lines 0 comments Download
D test/codegen/expect/server_mode/dir/html_input_c.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/codegen/expect/server_mode/dir/html_input_d.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/codegen/expect/server_mode/dir/html_input_e.js View 1 chunk +0 lines, -5 lines 0 comments Download
D test/codegen/expect/server_mode/html_input.html View 1 chunk +0 lines, -17 lines 0 comments Download
D test/codegen/expect/server_mode/html_input.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen_test.dart View 3 chunks +32 lines, -4 lines 1 comment Download
M tool/test.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 8 months ago (2015-04-01 18:47:16 UTC) #2
Jacob
lgtm
5 years, 8 months ago (2015-04-01 20:32:30 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as dd9ab2af960906485fb0df9de538bcd809d3f58e (presubmit successful).
5 years, 8 months ago (2015-04-01 20:49:14 UTC) #4
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-01 21:28:20 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1056613002/diff/1/test/codegen_test.dart
File test/codegen_test.dart (right):

https://codereview.chromium.org/1056613002/diff/1/test/codegen_test.dart#newc...
test/codegen_test.dart:272: if (dir.existsSync()) dir.deleteSync(recursive:
true);
minor nit: maybe just assert that it exists?

expect(dir.existsSync(), isTrue);
dir.deleteSync...

Powered by Google App Engine
This is Rietveld 408576698