Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 10566009: app_list: Fix shadow bleeds over launcher button and steals mouse events (Closed)

Created:
8 years, 6 months ago by xiyuan
Modified:
8 years, 6 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

app_list: Fix shadow bleeds over launcher button and steals mouse events - Add hit test mask to aura Window; - Use hit test mask to exclude shadow from hit test; BUG=132872 TEST=Verify mouse events reaches app list launcher button when app list bubble is shown. Clicking on top 3 rect of the 3x3 grid icon should dismiss app list and mouse hover there should have a hover effect. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142582

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, fix nit in #1 #

Patch Set 3 : fix aura_demo compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -17 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M ui/app_list/app_list_bubble_border.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list_bubble_border.cc View 3 chunks +17 lines, -1 line 0 comments Download
M ui/app_list/app_list_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list_view.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 3 chunks +18 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M ui/aura/window_delegate.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 3 chunks +23 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 6 chunks +18 lines, -9 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/widget_delegate.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
8 years, 6 months ago (2012-06-15 20:40:34 UTC) #1
sky
I'm passing this one to Ben.
8 years, 6 months ago (2012-06-15 22:25:44 UTC) #2
xiyuan
On 2012/06/15 22:25:44, sky wrote: > I'm passing this one to Ben. I was wondering ...
8 years, 6 months ago (2012-06-15 22:28:32 UTC) #3
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10566009/diff/1/ui/aura/window_delegate.h File ui/aura/window_delegate.h (right): http://codereview.chromium.org/10566009/diff/1/ui/aura/window_delegate.h#newcode89 ui/aura/window_delegate.h:89: // mask. It works similar to the vies ...
8 years, 6 months ago (2012-06-15 22:57:26 UTC) #4
xiyuan
http://codereview.chromium.org/10566009/diff/1/ui/aura/window_delegate.h File ui/aura/window_delegate.h (right): http://codereview.chromium.org/10566009/diff/1/ui/aura/window_delegate.h#newcode89 ui/aura/window_delegate.h:89: // mask. It works similar to the vies counterparts. ...
8 years, 6 months ago (2012-06-15 23:07:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10566009/13001
8 years, 6 months ago (2012-06-16 03:29:49 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-16 05:10:27 UTC) #7
Change committed as 142582

Powered by Google App Engine
This is Rietveld 408576698