Re-subimission of https://codereview.chromium.org/1041213003/

tools/perf/metrics/startup_metric.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import collections
 import json
 import logging
 
 from telemetry.core import exceptions
 from telemetry.value import histogram_util
 from telemetry.value import scalar
@@ skipping 29 matching lines @@
         tab)
     if high_bytes == 0 and low_bytes == 0:
       return None
     return (int(high_bytes) << 32) | (int(low_bytes) << 1)
 
   def _RecordTabLoadTimes(self, tab, browser_main_entry_time_ms, results):
     """Records the tab load times for the browser. """
     tab_load_times = []
     TabLoadTime = collections.namedtuple(
         'TabLoadTime',
-        ['load_start_ms', 'load_duration_ms', 'request_start_ms'])
+        ['request_start_ms', 'load_end_ms'])
 
     def RecordTabLoadTime(t):
+      def EvaluateInt(exp):
+        val = t.EvaluateJavaScript(exp)
+        if not val:
+          logging.warn('%s undefined' % exp)
+          return 0
+        return int(val)
+
       try:
-        t.WaitForDocumentReadyStateToBeComplete()
+        t.WaitForJavaScriptExpression(
+            'window.performance.timing["loadEventEnd"] > 0', 10)
 
-        result = t.EvaluateJavaScript(
-            'statsCollectionController.tabLoadTiming()')
-        result = json.loads(result)
+        # EvaluateJavaScript(window.performance.timing) doesn't guarantee to
+        # return the desired javascript object (crbug/472603). It may return an
+        # empty object. However getting individual field works.
+        # The behavior depends on Webkit implementation on different platforms.
+        load_event_end = EvaluateInt(
+            'window.performance.timing["loadEventEnd"]')
+        request_start = EvaluateInt(
+            'window.performance.timing["requestStart"]')
 
-        if 'load_start_ms' not in result or 'load_duration_ms' not in result:
-          raise Exception("Outdated Chrome version, "
-              "statsCollectionController.tabLoadTiming() not present")
-        if result['load_duration_ms'] is None:
-          tab_title = t.EvaluateJavaScript('document.title')
-          print "Page: ", tab_title, " didn't finish loading."
-          return
+        tab_load_times.append(TabLoadTime(request_start, load_event_end))

[nednguyen, 2015/04/03 21:24:59]

Why do we need to use a list here? Seems like this list always have length=1 and
we only access tab_load_times[0]

[cylee1, 2015/04/03 21:26:57]

I dont' know. It's how it was originally.
Do you suggest a refactoring in this CL? 

[nednguyen, 2015/04/03 21:28:36]

I prefer refactoring work to be done in a different patch :-)

 
-        perf_timing = t.EvaluateJavaScript('window.performance.timing')
-        if 'requestStart' not in perf_timing:
-          perf_timing['requestStart'] = 0  # Exclude from benchmark results
-          print 'requestStart is not supported by this browser'
-
-        tab_load_times.append(TabLoadTime(
-            int(result['load_start_ms']),
-            int(result['load_duration_ms']),
-            int(perf_timing['requestStart'])))
       except exceptions.TimeoutException:
         # Low memory Android devices may not be able to load more than
         # one tab at a time, so may timeout when the test attempts to
         # access a background tab. Ignore these tabs.
         logging.error("Tab timed out on JavaScript access")
 
     # Only measure the foreground tab. We can't measure all tabs on Android
     # because on Android the data of the background tabs is loaded on demand,
     # when the user switches to them, rather than during startup. In view of
     # this, to get the same measures on all platform, we only measure the
     # foreground tab on all platforms.
 
     RecordTabLoadTime(tab.browser.foreground_tab)
 
     foreground_tab_stats = tab_load_times[0]

[nednguyen, 2015/04/03 22:07:08]

If the TimeoutExceptions is thrown above, wouldn't this make tab_load_times
empty and creates a KeyError? Should we fail more gracefully here?

[cylee1, 2015/04/07 09:37:50]

True, it was a legacy issue. 
Did a tiny refactoring to resolve it.

-    foreground_tab_load_complete = ((foreground_tab_stats.load_start_ms +
-        foreground_tab_stats.load_duration_ms) - browser_main_entry_time_ms)
+    foreground_tab_load_complete = (
+        foreground_tab_stats.load_end_ms - browser_main_entry_time_ms)
     results.AddValue(scalar.ScalarValue(
         results.current_page, 'foreground_tab_load_complete', 'ms',
         foreground_tab_load_complete))
     if (foreground_tab_stats.request_start_ms > 0):
       results.AddValue(scalar.ScalarValue(
           results.current_page, 'foreground_tab_request_start', 'ms',
           foreground_tab_stats.request_start_ms - browser_main_entry_time_ms))
 
   def AddResults(self, tab, results):
     get_histogram_js = 'statsCollectionController.getBrowserHistogram("%s")'
@@ skipping 13 matching lines @@
 
       results.AddValue(scalar.ScalarValue(
           results.current_page, display_name, 'ms', measured_time))
 
     # Get tab load times.
     browser_main_entry_time_ms = self._GetBrowserMainEntryTime(tab)
     if (browser_main_entry_time_ms is None):
       print "Outdated Chrome version, browser main entry time not supported."
       return
     self._RecordTabLoadTimes(tab, browser_main_entry_time_ms, results)