extensions/browser/guest_view/web_view/web_view_content_script_manager.cc - Issue 1056533002: Implement <webview>.addContentScript/removeContentScript API [2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_content_script_manager.cc

Issue 1056533002: Implement <webview>.addContentScript/removeContentScript API [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webview_addremove_contentscripts_2

Patch Set: nits. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_content_script_manager.h ('k') | extensions/browser/user_script_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_content_script_manager.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_content_script_manager.cc b/extensions/browser/guest_view/web_view/web_view_content_script_manager.cc

index 163934cf757c0c6edddb5bd8514a840e96af5c13..15ede19ff331f09e80ce3c4bd568ea9fcfbe411b 100644

--- a/extensions/browser/guest_view/web_view/web_view_content_script_manager.cc

+++ b/extensions/browser/guest_view/web_view/web_view_content_script_manager.cc

@@ -109,6 +109,7 @@ WebViewContentScriptManager* WebViewContentScriptManager::Get(

void WebViewContentScriptManager::AddContentScripts(

content::WebContents* embedder_web_contents,

+ int embedder_routing_id,

int view_instance_id,

const HostID& host_id,

const std::set<UserScript>& scripts) {

@@ -153,7 +154,7 @@ void WebViewContentScriptManager::AddContentScripts(

}

// Step 3: adds new scripts to the master.

- master->AddScripts(scripts);

+ master->AddScripts(scripts, embedder_process_id, embedder_routing_id);

// Step 4: creates owner web contents observer for the given

// |embedder_web_contents| if it doesn't exist.