Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/execute_code_function.h

Issue 1056533002: Implement <webview>.addContentScript/removeContentScript API [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webview_addremove_contentscripts_2
Patch Set: Another round of comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/webview_execute_script_test.js ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.h » ('j') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/execute_code_function.h
diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h
index 3dd862b129db4d4bfac9051e2e8ee05273542c8f..de0f44e200f2f251168f2894e7ad6d6a17452aca 100644
--- a/extensions/browser/api/execute_code_function.h
+++ b/extensions/browser/api/execute_code_function.h
@@ -40,9 +40,9 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
virtual bool LoadFile(const std::string& file);
// Called when contents from the loaded file have been localized.
- void DidLoadAndLocalizeFile(const std::string& file,
- bool success,
- const std::string& data);
+ virtual void DidLoadAndLocalizeFile(const std::string& file,
+ bool success,
+ const std::string& data);
const HostID& host_id() const { return host_id_; }
void set_host_id(HostID host_id) {
« no previous file with comments | « chrome/test/data/webui/webview_execute_script_test.js ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.h » ('j') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698