Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

Issue 1056533002: Implement <webview>.addContentScript/removeContentScript API [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webview_addremove_contentscripts_2
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.h
diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
index 373abcec8b54d33ca47859397732fd8b18391b97..f9b5143d92ff0138302aff619f2d69ac60bfd921 100644
--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
@@ -8,6 +8,7 @@
#include "extensions/browser/api/capture_web_contents_function.h"
#include "extensions/browser/api/execute_code_function.h"
#include "extensions/browser/extension_function.h"
+#include "extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h"
#include "extensions/browser/guest_view/web_view/web_view_guest.h"
// WARNING: WebViewInternal could be loaded in an unblessed context, thus any
@@ -54,11 +55,6 @@ class WebViewInternalExecuteCodeFunction
: public extensions::ExecuteCodeFunction {
public:
WebViewInternalExecuteCodeFunction();
- // Called when a file URL request is complete.
- // Parameters:
- // - whether the request is success.
- // - If yes, the content of the file.
- using WebUILoadFileCallback = base::Callback<void(bool, const std::string&)>;
protected:
~WebViewInternalExecuteCodeFunction() override;
@@ -74,11 +70,9 @@ class WebViewInternalExecuteCodeFunction
bool LoadFile(const std::string& file) override;
private:
- class WebUIURLFetcher;
-
// Loads a file url on WebUI.
bool LoadFileForWebUI(const std::string& file_src,
- const WebUILoadFileCallback& callback);
+ const WebUIURLFetcher::WebUILoadFileCallback& callback);
// Contains extension resource built from path of file which is
// specified in JSON arguments.

Powered by Google App Engine
This is Rietveld 408576698