Implement <webview>.addContentScript/removeContentScript API [2]

extensions/browser/declarative_user_script_master.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_DECLARATIVE_USER_SCRIPT_MASTER_H_
 #define EXTENSIONS_BROWSER_DECLARATIVE_USER_SCRIPT_MASTER_H_
 
 #include "base/scoped_observer.h"
-#include "extensions/browser/extension_user_script_loader.h"
+#include "extensions/browser/user_script_loader.h"

[Devlin, 2015/04/22 21:15:33]

I think a forward declaration would work for this.

[Xi Han, 2015/04/22 22:33:59]

Since we declare scoped_ptr<UserScriptLoader> loader_, we have to include this
file.

[Devlin, 2015/04/22 23:20:50]

scoped_ptr requires only a forward declaration, not the whole file.

[Xi Han, 2015/04/23 15:01:55]

Done.

 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 
 class UserScript;
 
 // Manages declarative user scripts for a single extension. Owns a
 // UserScriptLoader to which file loading and shared memory management
 // operations are delegated, and provides an interface for adding, removing,
 // and clearing scripts.
 class DeclarativeUserScriptMaster {
  public:
   DeclarativeUserScriptMaster(content::BrowserContext* browser_context,
                               const HostID& host_id);
   ~DeclarativeUserScriptMaster();
 
   // Adds script to shared memory region. This may not happen right away if a
   // script load is in progress.
   void AddScript(const UserScript& script);
 
-  // Adds a set of scripts to shared memory region. This may not happen right
-  // away if a script load is in progress.
-  void AddScripts(const std::set<UserScript>& scripts);
+  // Adds a set of scripts to shared meomory region. The fetch of the content
+  // of the script on WebUI requires to start URL request to the associated
+  // render specified by |render_process_id, render_view_id|.
+  // This may not happen right away if a script load is in progress.
+  void AddScripts(const std::set<UserScript>& scripts,
+                  int render_process_id,

[Devlin, 2015/04/22 21:15:33]

It's kind of a shame to have the render process/view ids here, because it
shouldn't really be needed.  But the workaround is a lot more effort, and the
layering violation is relatively small.  So how about just
TODO(hanxi): The renderer information doesn't really belong in this base class,
but it's not an easy fix.

[Xi Han, 2015/04/22 22:33:59]

Sounds fair to me.

+                  int render_view_id);
 
   // Removes script from shared memory region. This may not happen right away if
   // a script load is in progress.
   void RemoveScript(const UserScript& script);
 
   // Removes a set of scripts from shared memory region. This may not happen
   // right away if a script load is in progress.
   void RemoveScripts(const std::set<UserScript>& scripts);
 
   // Removes all scripts from shared memory region. This may not happen right
   // away if a script load is in progress.
   void ClearScripts();
 
   const HostID& host_id() const { return host_id_; }
 
  private:
   // ID of host that owns scripts that this component manages.
   HostID host_id_;
 
   // Script loader that handles loading contents of scripts into shared memory
   // and notifying renderers of script updates.
-  ExtensionUserScriptLoader loader_;
+  scoped_ptr<UserScriptLoader> loader_;
 
   DISALLOW_COPY_AND_ASSIGN(DeclarativeUserScriptMaster);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_DECLARATIVE_USER_SCRIPT_MASTER_H_