Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1056433002: Include DirectoryExists to libbase_nacl_nonsfi.a. (Closed)

Created:
5 years, 8 months ago by hidehiko
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, Mark Seaborn, jln (very slow on Chromium), mdempsky, rickyz (no longer on Chrome), hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include DirectoryExists to libbase_nacl_nonsfi.a. DirectoryExists will be used by sandbox/ code for nacl_helper_nonsfi. This CL is the preparation for it. TEST=Run bots. BUG=464663 Committed: https://crrev.com/1b30fcb34c1164b4c2bbb05fd64a7b7056ba69fb Cr-Commit-Position: refs/heads/master@{#323286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/files/file_util_posix.cc View 5 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hidehiko
Hello Lei, Could you take a look at this CL? Background: we're implementing sandbox for ...
5 years, 8 months ago (2015-04-01 12:07:54 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-01 18:11:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056433002/1
5 years, 8 months ago (2015-04-01 18:11:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 18:31:26 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 18:32:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b30fcb34c1164b4c2bbb05fd64a7b7056ba69fb
Cr-Commit-Position: refs/heads/master@{#323286}

Powered by Google App Engine
This is Rietveld 408576698