Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1056423002: [bindings] Include copyright block in generated code for consistency. (Closed)

Created:
5 years, 8 months ago by vivekg_samsung
Modified:
5 years, 8 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Include copyright block in generated code for consistency. Adding copyright_block.txt to have the copyright block at one place to avoid any inconsistencies. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -67 lines) Patch
M Source/bindings/templates/callback_interface.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +1 line, -6 lines 0 comments Download
A + Source/bindings/templates/copyright_block.txt View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/templates/dictionary_impl.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/dictionary_impl.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/partial_interface.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/templates.gni View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/templates.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/union.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/bindings/templates/union.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
PTAL. Did some changes to have the year '2014' also being taken from datetime.date.today().year but ...
5 years, 8 months ago (2015-04-06 12:06:28 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-06 15:27:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056423002/1
5 years, 8 months ago (2015-04-06 15:30:18 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 15:34:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193192

Powered by Google App Engine
This is Rietveld 408576698