Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1056413002: Files.app: Show progress bar for file open dialog. (Closed)

Created:
5 years, 8 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Show progress bar for file open dialog. We have progress bar on dialog footer, and it should show for file open dialog that needs local cache file for drive files. (e.g. dialog called by NPAPI plugin) Also the CL adjust mergin so that "Preparing..." label should be placed with the correct margin no matter if the "New directory" button is shown or not. BUG=459876 TEST=manually Committed: https://crrev.com/e213b035d9b557421fc918c055c09bc11b460788 Cr-Commit-Position: refs/heads/master@{#323893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +5 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 8 months ago (2015-04-06 05:11:30 UTC) #2
fukino
lgtm!
5 years, 8 months ago (2015-04-06 05:19:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056413002/1
5 years, 8 months ago (2015-04-06 05:25:27 UTC) #5
hirono
On 2015/04/06 05:19:04, fukino wrote: > lgtm! Thanks!
5 years, 8 months ago (2015-04-06 05:25:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 05:35:06 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 05:35:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e213b035d9b557421fc918c055c09bc11b460788
Cr-Commit-Position: refs/heads/master@{#323893}

Powered by Google App Engine
This is Rietveld 408576698