Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1056383002: Refresh Public Suffix List to the latest version (Closed)

Created:
5 years, 8 months ago by Ryan Sleevi
Modified:
5 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffix List to the latest version This updates to the following revision: 4f90008545e0 (2015-04-02 03:34 -0400) It includes changes from revision bad2a08db205 (2015-02-17 17:53 +0000) to revision 4f90008545e0 (2015-04-02 03:34 -0400), listed at http://hg.mozilla.org/mozilla-central/log/4f90008545e0/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/7faf645e3ebfe310cfbd5b2dbc5b459e4af93cb2 Cr-Commit-Position: refs/heads/master@{#323933}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -25 lines) Patch
M net/base/net_util_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names.dat View 52 chunks +188 lines, -24 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 68 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ryan Sleevi
Nothing exciting this round. I've cross-referenced with the new gtld datasheet ( https://newgtlds.icann.org/newgtlds.csv ) and ...
5 years, 8 months ago (2015-04-06 03:27:04 UTC) #1
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-06 10:04:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056383002/1
5 years, 8 months ago (2015-04-06 13:44:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/12063)
5 years, 8 months ago (2015-04-06 14:40:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056383002/20001
5 years, 8 months ago (2015-04-06 18:39:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 19:33:45 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 19:34:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7faf645e3ebfe310cfbd5b2dbc5b459e4af93cb2
Cr-Commit-Position: refs/heads/master@{#323933}

Powered by Google App Engine
This is Rietveld 408576698